Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optimize i18n of community #868

Merged
merged 7 commits into from
Feb 10, 2022
Merged

feat: optimize i18n of community #868

merged 7 commits into from
Feb 10, 2022

Conversation

h1z3y3
Copy link
Contributor

@h1z3y3 h1z3y3 commented Jan 29, 2022 •
edited
Loading

@deining Thanks a lot for the reply in #864, I didn't know the method before.

I copied German from #867
and copied Spanish from #866

Please @deining & @eyllanesc help me to review, appreciate it.

What's more, I fix some leaks of tag (</p>) in the community_links.html file.

@eyllanesc
Copy link

@h1z3y3 Is there a preview where you can see "community" tab in other languages to review it? On the other hand, I see that the change is correct.

@deining
Copy link
Collaborator

deining commented Jan 29, 2022

@h1z3y3 Is there a preview where you can see "community" tab in other languages to review it?

What you can do (workaround): temporarily rename es.toml to en.toml, preview the site and make changes as needed. Then rename en.toml to es.toml again and restore original en.toml.

deining
deining suggested changes Jan 29, 2022
View reviewed changes
Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments below:

i18n/de.toml Outdated Show resolved Hide resolved
i18n/de.toml Outdated Show resolved Hide resolved
@h1z3y3
Copy link
Contributor Author

h1z3y3 commented Jan 30, 2022

@h1z3y3 Is there a preview where you can see "community" tab in other languages to review it? On the other hand, I see that the change is correct.

Thanks

@h1z3y3 h1z3y3 requested a review from deining January 30, 2022 03:11
@eyllanesc
Copy link

eyllanesc commented Jan 30, 2022 •
edited
Loading

@h1z3y3 Also change to

[community_join]
other = "Únete a la Comunidad {{ .Site.Title }}"

deining
deining suggested changes Jan 30, 2022
View reviewed changes
Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are close to approval now!
Some minor issues remain though:

i18n/en.toml Outdated Show resolved Hide resolved
i18n/de.toml Outdated Show resolved Hide resolved
@h1z3y3
Copy link
Contributor Author

h1z3y3 commented Jan 31, 2022

@eyllanesc & @deining
Thanks for your patience and kindness !

@eyllanesc
Copy link

@h1z3y3 I think that next time you should change en.toml and then the rest of us can see the change and also contribute in the other languages so you won't need our comments.

@h1z3y3
Copy link
Contributor Author

h1z3y3 commented Jan 31, 2022

@h1z3y3 I think that next time you should change en.toml and then the rest of us can see the change and also contribute in the other languages so you won't need our comments.

It makes sense, thanks a lot!

geriom
geriom requested changes Jan 31, 2022
View reviewed changes
Copy link
Collaborator

@geriom geriom left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits about the Spanish translation.

i18n/es.toml Outdated Show resolved Hide resolved
i18n/es.toml Outdated Show resolved Hide resolved
i18n/es.toml Outdated Show resolved Hide resolved
deining
deining approved these changes Feb 1, 2022
View reviewed changes
Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made to de.toml seem to be fine for me.

This was referenced Feb 2, 2022
Closed
Closed
@chalin
Copy link
Collaborator

chalin commented Feb 3, 2022

Hi @h1z3y3: once you make the changes requested by @geriom and he re-approves, I'll merge this PR.

@h1z3y3
Copy link
Contributor Author

h1z3y3 commented Feb 4, 2022

@geriom @eyllanesc Please re-approves.

@h1z3y3 h1z3y3 requested a review from geriom February 4, 2022 02:37
@LisaFC
Copy link
Collaborator

LisaFC commented Feb 9, 2022

@geriom can you take a look at this so we can merge it?

geriom
geriom approved these changes Feb 10, 2022
View reviewed changes
Copy link
Collaborator

@geriom geriom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments. LGTM

@chalin
Copy link
Collaborator

chalin commented Feb 10, 2022

Thanks all!

@chalin chalin merged commit 9bd8121 into google:master Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyllanesc eyllanesc eyllanesc left review comments

@geriom geriom geriom approved these changes

@deining deining Awaiting requested review from deining

Assignees

@h1z3y3 h1z3y3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@h1z3y3 @eyllanesc @deining @chalin @LisaFC @geriom